Skip to content

HADOOP-18139. Allow configuration of zookeeper server principal.#4024

Closed
omalley wants to merge 2 commits intoapache:branch-3.3from
omalley:hadoop-18139
Closed

HADOOP-18139. Allow configuration of zookeeper server principal.#4024
omalley wants to merge 2 commits intoapache:branch-3.3from
omalley:hadoop-18139

Conversation

@omalley
Copy link
Contributor

@omalley omalley commented Feb 24, 2022

Description of PR

This change allows RBF routers to configure the principal the ZK servers run as.

How was this patch tested?

Running in an integration cluster.

@omalley
HADOOP-18139: RBF: Allow configuration of zookeeper server principals.
450528f 
Cherry-picked from 8b3377a9 by Owen O'Malley

Cherry-picked from ccbdc3cf by Owen O'Malley
@hadoop-yetus
Copy link

hadoop-yetus commented Feb 24, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 31m 17s branch-3.3 passed
+1 💚 compile 17m 25s branch-3.3 passed
+1 💚 checkstyle 0m 57s branch-3.3 passed
+1 💚 mvnsite 1m 35s branch-3.3 passed
+1 💚 javadoc 1m 48s branch-3.3 passed
+1 💚 spotbugs 2m 24s branch-3.3 passed
+1 💚 shadedclient 25m 14s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 57s the patch passed
+1 💚 compile 16m 47s the patch passed
+1 💚 javac 16m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 55s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74)
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 javadoc 1m 40s the patch passed
+1 💚 spotbugs 2m 33s the patch passed
+1 💚 shadedclient 25m 20s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 16s hadoop-common in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
155m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/3/artifact/out/Dockerfile
GITHUB PR #4024
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 9caf7a5bd850 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 450528f
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/3/testReport/
Max. process+thread count 2152 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/3/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Feb 24, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 13m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 31m 0s branch-3.3 passed
+1 💚 compile 17m 20s branch-3.3 passed
+1 💚 checkstyle 0m 54s branch-3.3 passed
+1 💚 mvnsite 1m 36s branch-3.3 passed
+1 💚 javadoc 1m 47s branch-3.3 passed
+1 💚 spotbugs 2m 23s branch-3.3 passed
+1 💚 shadedclient 25m 9s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 53s the patch passed
+1 💚 compile 16m 43s the patch passed
+1 💚 javac 16m 43s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 53s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74)
+1 💚 mvnsite 1m 32s the patch passed
+1 💚 javadoc 1m 42s the patch passed
+1 💚 spotbugs 2m 33s the patch passed
+1 💚 shadedclient 25m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 13s hadoop-common in the patch passed.
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
160m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/2/artifact/out/Dockerfile
GITHUB PR #4024
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 058a76bc18fe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 450528f
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/2/testReport/
Max. process+thread count 3158 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Feb 24, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 14m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 33m 57s branch-3.3 passed
+1 💚 compile 18m 14s branch-3.3 passed
+1 💚 checkstyle 0m 47s branch-3.3 passed
+1 💚 mvnsite 1m 30s branch-3.3 passed
+1 💚 javadoc 1m 37s branch-3.3 passed
+1 💚 spotbugs 2m 23s branch-3.3 passed
+1 💚 shadedclient 26m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 56s the patch passed
+1 💚 compile 17m 24s the patch passed
+1 💚 javac 17m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 46s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74)
+1 💚 mvnsite 1m 28s the patch passed
+1 💚 javadoc 1m 36s the patch passed
+1 💚 spotbugs 2m 31s the patch passed
+1 💚 shadedclient 26m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 9s hadoop-common in the patch passed.
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
167m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/1/artifact/out/Dockerfile
GITHUB PR #4024
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 2e6d32ddd55b 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 450528f
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/1/testReport/
Max. process+thread count 3098 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@omalley
Copy link
Contributor Author

omalley commented Feb 24, 2022

I looked into adding unit tests, but the test zookeeper instance that the unit tests use doesn't support security, so it can't test this patch, which only matters if the zookeeper service is running with kerberos authentication.

@goiri goiri changed the title Hadoop 18139 HADOOP-18139. Allow configuration of zookeeper server principal. Feb 24, 2022
@hadoop-yetus
Copy link

hadoop-yetus commented Feb 24, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 40m 37s branch-3.3 passed
+1 💚 compile 24m 1s branch-3.3 passed
+1 💚 checkstyle 1m 4s branch-3.3 passed
+1 💚 mvnsite 2m 9s branch-3.3 passed
+1 💚 javadoc 2m 2s branch-3.3 passed
+1 💚 spotbugs 3m 7s branch-3.3 passed
+1 💚 shadedclient 31m 36s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 9s the patch passed
+1 💚 compile 23m 21s the patch passed
+1 💚 javac 23m 21s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 mvnsite 1m 52s the patch passed
+1 💚 javadoc 1m 51s the patch passed
+1 💚 spotbugs 3m 4s the patch passed
+1 💚 shadedclient 30m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 10s hadoop-common in the patch passed.
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
184m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/4/artifact/out/Dockerfile
GITHUB PR #4024
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 79363f83193d 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / fc4bf4a
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/4/testReport/
Max. process+thread count 2575 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4024/4/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@omalley omalley closed this in 12fa38d Feb 24, 2022
omalley added a commit that referenced this pull request Feb 24, 2022
@omalley
HADOOP-18139: Allow configuration of zookeeper server principal.
1a3060d 
Fixes #4024

Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
cbaenziger pushed a commit to cbaenziger/hadoop that referenced this pull request Mar 8, 2022
@omalley @cbaenziger
HADOOP-18139: Allow configuration of zookeeper server principal.
2b848d1 
Fixes apache#4024

Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@omalley
HADOOP-18139: Allow configuration of zookeeper server principal.
23c7a72 
Fixes apache#4024

Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simbadzina simbadzina simbadzina requested changes

@goiri goiri goiri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omalley @hadoop-yetus @goiri @simbadzina